Oh, sorry, I missed the reply before sending the vote mail

For the authorization, I think users are responsible for doing that, just
like what they do while setting the log topic for functions.

And it's easy to distinguish logs if one log topic is used for multiple
functions because the producer will add `fqn` to the property while sending
log entry to pulsar in here
<https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/LogAppender.java#L60-L67>
:

```java
    public void append(LogEvent logEvent) {
        producer.newMessage()

.value(logEvent.getMessage().getFormattedMessage().getBytes(StandardCharsets.UTF_8))
                .property(LOG_LEVEL, logEvent.getLevel().name())
                .property(INSTANCE, instance)
                .property(FQN, fqn)
                .sendAsync();
    }
```



Regards,
Pengcheng Jiang

PengHui Li <peng...@apache.org> 于2024年2月26日周一 09:48写道:

> Do we need to take the authorization into account?
> Users might need to take one more step to grant permission to access the
> log topic.
> It is better to mention it in the proposal.
>
> If users try to use one log topic for multiple functions,
> Is it easy for them to distinguish which function the logs are from?
>
> Regards,
> Penghui
>
> On Tue, Feb 20, 2024 at 9:03 AM Pengcheng Jiang
> <pengcheng.ji...@streamnative.io.invalid> wrote:
>
> > Sorry, the PIP number should be PIP-339
> >
> > Pengcheng Jiang <pengcheng.ji...@streamnative.io> 于2024年2月19日周一 17:30写道:
> >
> > > Dear community,
> > >
> > > I created a PIP to support `--log-topic` for Pulsar Sinks and Sources:
> > > https://github.com/apache/pulsar/pull/22071
> > >
> > > It will make Pulsar Functions and Connectors have the same way to
> manage
> > > their logs.
> > >
> > > Any feedback and suggestions are welcome.
> > >
> > > Sincerely
> > > Pengcheng Jiang
> > >
> >
>

Reply via email to