+1 (binding) - Verified checksum and signatures - Built from source on macOS m1 - Ran the tests
Regards Jiwei Guo (Tboy) On Thu, Mar 14, 2024 at 9:12 PM Yunze Xu <x...@apache.org> wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source on macOS m1 > - Upgrade the dependency of the python client and verified the issues > are fixed (https://github.com/apache/pulsar-client-python/pull/202) > > Thanks, > Yunze > > On Thu, Mar 14, 2024 at 6:13 PM Yunze Xu <x...@apache.org> wrote: > > > > The vcpkg submodule is just convenient for development. You can just > > run `git clone https://github.com/microsoft/vcpkg.git` > <https://github.com/microsoft/vcpkg.git> in the source > > directory instead of fetching the submodule. > > > > BTW, I just found that when INTEGRATE_VCPKG is ON, we cannot customize > > the CMAKE_TOOLCHAIN_FILE. So I opened a PR to fix it. > > https://github.com/apache/pulsar-client-cpp/pull/417 > > > > Thanks, > > Yunze > > > > On Thu, Mar 14, 2024 at 3:47 PM Baodi Shi <ba...@apache.org> wrote: > > > > > > Hi, yunze > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.5.0-candidate-2/apache-pulsar-client-cpp-3.5.0.tar.gz > > > This source code not include vcpkg, If we unzip it and run the command > cmake > > > -B build -DINTEGRATE_VCPKG=ON, it throws an error. Do we need to > include > > > vcpkg in the source code? > > > > > > > > > Other passed verify: > > > - Checked the sign and checksum > > > - Use macOS arm64 pre-built binaries to build node.js client > > > > > > > > > > > > > > > Thanks, > > > Baodi Shi > > > > > > > > > On Mar 12, 2024 at 10:25:56, Yunze Xu <x...@apache.org> wrote: > > > > > > > This is the second release candidate for Apache Pulsar Client C++, > > > > version 3.5.0. > > > > > > > > It fixes the following issues: > > > > https://github.com/apache/pulsar-client-cpp/milestone/6?closed=1 > > > > > > > > *** Please download, test and vote on this release. This vote will > stay > > > > open > > > > for at least 72 hours *** > > > > > > > > Note that we are voting upon the source (tag), binaries are provided > for > > > > convenience. > > > > > > > > Source and binary files: > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.5.0-candidate-2/ > > > > > > > > SHA-512 checksums: > > > > > > > > > > > > > b590c7128a0110812e3a2f3b94f81078a3ff254709aab175265838fa45c4022f0fab83d4817c1d31883a68e49454c698d0ea7b858c4b7e8d756aa1f7f703fe12 > > > > apache-pulsar-client-cpp-3.5.0.tar.gz > > > > > > > > > > > > The tag to be voted upon: > > > > v3.5.0-candidate-2 (916af95dda4d06162f9ea4e4180f9fd726c25a4e) > > > > > https://github.com/apache/pulsar-client-cpp/releases/tag/v3.5.0-candidate-2 > > > > > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > > > https://downloads.apache.org/pulsar/KEYS > > > > > > > > Please download the source package, and follow > > > > > > > > > https://github.com/apache/pulsar-client-cpp/wiki/Verify-the-candidate-release-in-your-local-env > > > > to compile and test. > > > > > > > > Note: If you're going to run the unit tests locally, please make sure > > > > the proxy is disabled. > > > > >
