Sorry, I forgot to submit my PR review before. Just some minor comments about the names. Please take a look.
Regards, Penghui On Fri, Mar 22, 2024 at 11:21 PM Matteo Merli <matteo.me...@gmail.com> wrote: > Closing this vote with 4 binding and 4 non-binding +1s > > Binding +1s: > * Lari > * Mattison > * PengHui > * Matteo > > Non-Binding +1s: > * Dao Jun > * Apurva > * Asaf > * Zixuan > > > Thanks, > Matteo > > > -- > Matteo Merli > <matteo.me...@gmail.com> > > > On Thu, Mar 14, 2024 at 11:54 PM Zixuan Liu <node...@gmail.com> wrote: > > > +1 (non-binding) > > > > Thanks, > > Zixuan > > > > PengHui Li <peng...@apache.org> 于2024年3月15日周五 09:47写道： > > > > > +1 (binding) > > > > > > Regards, > > > Penghui > > > > > > On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika <asaf.mes...@gmail.com> > > wrote: > > > > > > > +1 (non-binding) > > > > > > > > On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang < > > apurvatelan...@gmail.com> > > > > wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > On Thu, Mar 14, 2024 at 2:12 AM mattison chao < > > mattisonc...@gmail.com> > > > > > wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > Best, > > > > > > Mattison > > > > > > On Mar 14, 2024 at 15:55 +0800, Lari Hotari <lhot...@apache.org > >, > > > > wrote: > > > > > > > +1 (binding) > > > > > > > > > > > > > > -Lari > > > > > > > > > > > > > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli < > > matteo.me...@gmail.com > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > PIP: https://github.com/apache/pulsar/pull/22178 > > > > > > > > > > > > > > > > WIP PR: https://github.com/apache/pulsar/pull/22179 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Matteo Merli > > > > > > > > <matteo.me...@gmail.com> > > > > > > > > > > > > > > > > > > > > > -- > > > > > Best regards, > > > > > Apurva Telang. > > > > > > > > > > > > > > >
