Thanks reminder, it related this
https://github.com/apache/pulsar-client-node/pull/301 pr, let me research
it.
I will cancel this vote
Thanks,
Baodi Shi
On Apr 12, 2024 at 10:46:57, Zike Yang <z...@apache.org> wrote:
> - Verified checksum and signature
> - Built from source on macOS arm64 and run the example
> - Installed from the npm registry and run the example
> - Installed from the npm registry on Ubuntu using Node v14, v16, v18
> and run the example
>
> Installed from the npm registry using node v10, v11, v12, v13 but if
> failed with the following errors:
> ```
>
> pulsar-client@1.11.0-rc.3 install
> /data/verify/node1-11/node_modules/pulsar-client
>
> node-pre-gyp install --fallback-to-build && node GenCertFile.js
>
>
> [pulsar-client] Success:
> "/data/verify/node1-11/node_modules/pulsar-client/lib/binding/pulsar.node"
> is installed via remote
> /data/verify/node1-11/node_modules/pulsar-client/src/Client.js:60
> fs.rmSync(certsFilePath, { force: true });
> ^
>
> TypeError: fs.rmSync is not a function
> at Function.genCertFile
> (/data/verify/node1-11/node_modules/pulsar-client/src/Client.js:60:8)
> at Object.<anonymous>
> (/data/verify/node1-11/node_modules/pulsar-client/GenCertFile.js:22:8)
> at Module._compile (internal/modules/cjs/loader.js:1118:30)
> at Object.Module._extensions..js
> (internal/modules/cjs/loader.js:1138:10)
> at Module.load (internal/modules/cjs/loader.js:982:32)
> at Function.Module._load (internal/modules/cjs/loader.js:875:14)
> at Function.executeUserEntryPoint [as runMain]
> (internal/modules/run_main.js:71:12)
> at internal/main/run_main_module.js:17:47
> npm WARN node1-11@1.0.0 No description
> npm WARN node1-11@1.0.0 No repository field.
>
> npm ERR! code ELIFECYCLE
> npm ERR! errno 1
> npm ERR! pulsar-client@1.11.0-rc.3 install: `node-pre-gyp install
> --fallback-to-build && node GenCertFile.js`
> npm ERR! Exit status 1
> npm ERR!
> npm ERR! Failed at the pulsar-client@1.11.0-rc.3 install script.
> npm ERR! This is probably not a problem with npm. There is likely
> additional logging output above.
>
> npm ERR! A complete log of this run can be found in:
> npm ERR! /home/zike/.npm/_logs/2024-04-12T02_40_33_159Z-debug.log
> ```
>
> However the README states that the client is compatible with Nodejs 10
> or later:
> https://github.com/apache/pulsar-client-node/blob/e3bf582ea450e68379ff685598257ed6e69fb1aa/README.md?plain=1#L26
> Perhaps we should update our version compatibility strategy in the
> README.
>
> BR,
> Zike Yang
>
> On Fri, Apr 12, 2024 at 8:13 AM Baodi Shi <ba...@apache.org> wrote:
>
>
> +1(binding)
>
>
> - verified sign and checksum
>
> - Build from source and install from npm registry on macOS arm64
>
> - Install from npm registry on Windows x64
>
> - Run ProducerSample and ConsumerSample on macOS
>
>
>
> Thanks,
>
> Baodi Shi
>
>
>
> On Apr 11, 2024 at 18:43:51, Yunze Xu <x...@apache.org> wrote:
>
>
> > +1 (binding)
>
> >
>
> > - Verified signature and checksums
>
> > - Built from source on macOS
>
> > - Run e2e tests against a local standalone
>
> > - Run e2e tests with OAuth2 authentication against an online cluster
>
> >
>
> > Thanks,
>
> > Yunze
>
> >
>
> > On Tue, Apr 9, 2024 at 6:26 PM Baodi Shi <ba...@apache.org> wrote:
>
> >
>
> >
>
> > Hi everyone,
>
> >
>
> >
>
> > This is the first release candidate for Apache Pulsar Node.js client,
>
> >
>
> > version 1.11.0.
>
> >
>
> >
>
> > It fixes the following issues:
>
> >
>
> > - https://github.com/apache/pulsar-client-node/milestone/16?closed=1
>
> >
>
> > - Related cpp client issue:
>
> >
>
> > https://github.com/apache/pulsar-client-cpp/compare/v3.4.2...v3.5.1
>
> >
>
> >
>
> > Please download the source files and review this release candidate:
>
> >
>
> > - Download the source package, verify shasum and asc
>
> >
>
> > - Follow the README.md to build and run the Pulsar Node.js client.
>
> >
>
> >
>
> > The release candidate package has been published to the npm registry:
>
> >
>
> > https://www.npmjs.com/package/pulsar-client/v/1.11.0-rc.3
>
> >
>
> > You can install it by `npm i pulsar-client@1.11.0-rc.3
>
> >
>
> > --pulsar_binary_host_mirror=
>
> >
>
> > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/` and
>
> >
>
> > verify the package.
>
> >
>
> >
>
> > The vote will be open for at least 72 hours. It is adopted by majority
>
> >
>
> > approval, with at least 3 PMC affirmative votes.
>
> >
>
> >
>
> > Source files:
>
> >
>
> >
>
> >
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/pulsar-client-node-1.11.0-rc.3/
>
> >
>
> >
>
> > Pulsar's KEYS file containing PGP keys we use to sign the release:
>
> >
>
> > https://downloads.apache.org/pulsar/KEYS
>
> >
>
> >
>
> > SHA-512 checksum:
>
> >
>
> >
>
> >
> 74196c05f80a0c2569c1d19d7e21ea18babb5fe75fc5936c6eef47574ee7a9abc0f4a7e4db3b740de760d477cb2dfc51c9fd5b2dd343ee54389d78b1e24849e7
>
> >
>
> > ./apache-pulsar-client-node-1.11.0.tar.gz
>
> >
>
> >
>
> > The tag to be voted upon:
>
> >
>
> > v1.11.0-rc.3
>
> >
>
> > https://github.com/apache/pulsar-client-node/releases/tag/v1.11.0-rc.3
>
> >
>
> >
>
> > Please review and vote on the release candidate #1 for the version
> 1.11.0,
>
> >
>
> > as follows:
>
> >
>
> > [ ] +1, Approve the release
>
> >
>
> > [ ] -1, Do not approve the release (please provide specific comments)
>
> >
>
> >
>
> >
>
> > Thanks,
>
> >
>
> > Baodi Shi
>
> >
>
> >
>
>
