Hi Jie, I support the PIP but there are something we need to consider: OpenTelemetry-javagent[1] and Apache Skywalking-javaagent[2] enhanced `SendCallback` to monitor sending messages, if we change the method sign, the java-agents can't work. It will be great that you can make it compatible, or, we have to push PRs to OpenTelemetry/Skywalking to fix it.
Links: [1] https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/pulsar/pulsar-2.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/pulsar/v2_8/ProducerImplInstrumentation.java [2] https://github.com/dao-jun/skywalking-java/blob/main/apm-sniffer/apm-sdk-plugin/pulsar-common/src/main/java/org/apache/skywalking/apm/plugin/pulsar/common/SendCallbackInterceptor.java Thanks, Tao Jiuming Zixuan Liu <node...@gmail.com> 于2024年6月21日周五 12:25写道： > +1 > > Jie crossover <crossover...@gmail.com> 于2024年6月19日周三 16:12写道： > > > Hi, Pulsar Community. > > > > I have created a PIP to add an `OpSendMsgStats` parameter to the > > `SendCallback` interface. > > This will help us implement `messaging.publish.messages` metric. > > PIP link: https://github.com/apache/pulsar/pull/22940 > > OpenTelemetry Messaging Metrics link: > > > > > https://opentelemetry.io/docs/specs/semconv/messaging/messaging-metrics/#metric-messagingpublishduration > > -- > > Best Regards！ > > crossoverJie > > >
