Hi -

> On Jun 26, 2017, at 10:17 AM, Matteo Merli <[email protected]> wrote:
> 
> I have added the apache-rat maven plugin and double checked the license
> headers status.
> 
> There were a few headers missing here and there (some config files, etc..).
> I have added
> the exclusions for generated files and for imported source files that have
> valid licenses (eg: we have some LZ4 related code which is under BSD
> 2-clause license and I believe it's safe to import in source distribution,
> given that we mention it in the NOTICE file).

Yes. See https://www.apache.org/legal/resolved.html.

I think that we will need to include the BSD License in the LICENSE file as 
well.

> 
> Dave, is it fine if the PR is coming from non-Yahoo employee this time?

Yes, I think that is fine.

> There is just one point where I am not sure. We have one file that contains
> the implementation for CRC32-C in software. This is used as a fallback in
> case the processor doesn't support SSE4.2 instructions.
> https://github.com/apache/incubator-pulsar/blob/master/pulsar-client-cpp/lib/checksum/crc32c_sw.cc
> 
> The license is not any "standard" one, though it looks very permissive.
> IANAL but as far as I can understand this just requires to maintain the
> header notice and not mis-represent the origin of this code.
> 
> ---------------------------------------------------------------
> /* crc32c.c -- compute CRC-32C using the Intel crc32 instruction
> * Copyright (C) 2013 Mark Adler
> * Version 1.1  1 Aug 2013  Mark Adler
> */
> 
> /*
> This software is provided 'as-is', without any express or implied
> warranty.  In no event will the author be held liable for any damages
> arising from the use of this software.
> Permission is granted to anyone to use this software for any purpose,
> including commercial applications, and to alter it and redistribute it
> freely, subject to the following restrictions:
> 1. The origin of this software must not be misrepresented; you must not
> claim that you wrote the original software. If you use this software
> in a product, an acknowledgment in the product documentation would be
> appreciated but is not required.
> 2. Altered source versions must be plainly marked as such, and must not be
> misrepresented as being the original software.
> 3. This notice may not be removed or altered from any source distribution.
> Mark Adler
> [email protected]
> */
> ------------------------------------------------------------------
> 
> 
> What are our options here? Should we ask for advice on the legal ML ?

You should open up a LEGAL lira to discuss on the legal-discuss email list.

I think that we will need to put some information in the NOTICE, but some will 
consider the source note as required to be enough.

Another question is if the special license must be in the LICENSE file.

Regards,
Dave


> 
> 
> 
> 
> --
> Matteo Merli
> <[email protected]>

Attachment: signature.asc
Description: Message signed with OpenPGP

Reply via email to