On Wed, Jul 5, 2017 at 1:56 PM, <g...@git.apache.org> wrote: > rdhabalia commented on a change in pull request #514: Static link > dependency libraries for C++ client lib and Python wrapper > URL: https://github.com/apache/incubator-pulsar/pull/514#discussi > on_r125755406 > > +find_library(LOG4CXX_LIBRARY_PATH NAMES liblog4cxx.a) > > Review comment: > `liblog4cxx.a` is this correct? >
( I don't know why this comment doesn't appear on the github PR page) liblog4cxx.a is to force cmake to link against the static library (that allows to remove the dependency on log4cxx, since it's like bundling the library inside libpulsar.so)
