jai1 commented on a change in pull request #615: Allow to compile C++ client lib in debug mode URL: https://github.com/apache/incubator-pulsar/pull/615#discussion_r130737106
########## File path: pulsar-client-cpp/CMakeLists.txt ########## @@ -23,13 +23,20 @@ project (pulsar-cpp) option(LINK_STATIC "Link against static libraries" OFF) MESSAGE(STATUS "LINK_STATIC: " ${LINK_STATIC}) +IF (CMAKE_BUILD_TYPE STREQUAL "") Review comment: IF (CMAKE_BUILD_TYPE STREQUAL "") MESSAGE(STATUS "CMAKE_BUILD_TYPE is set to default (Release)") else MESSAGE(STATUS "CMAKE_BUILD_TYPE: " ${CMAKE_BUILD_TYPE}) ENDIF (CMAKE_BUILD_TYPE STREQUAL "") `cmake -DCMAKE_BUILD_TYPE= RelWithDebInfo` when we run it in docker The reason is that the default value is Release. ------ Rest is ok ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services