merlimat commented on a change in pull request #615: Allow to compile C++ 
client lib in debug mode
URL: https://github.com/apache/incubator-pulsar/pull/615#discussion_r130738285
 
 

 ##########
 File path: pulsar-client-cpp/CMakeLists.txt
 ##########
 @@ -23,13 +23,20 @@ project (pulsar-cpp)
 option(LINK_STATIC "Link against static libraries" OFF)
 MESSAGE(STATUS "LINK_STATIC:  " ${LINK_STATIC})
 
+IF (CMAKE_BUILD_TYPE STREQUAL "")
 
 Review comment:
   In the PR build I've configured like: 
   
   ```shell
   echo "Build C++ client library"
   export CMAKE_ARGS="-DCMAKE_BUILD_TYPE=Debug"
   
   pulsar-client-cpp/docker-build.sh
   pulsar-client-cpp/docker-tests.sh
   
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to