rdhabalia commented on a change in pull request #619: make batch-ack thread-safe
URL: https://github.com/apache/incubator-pulsar/pull/619#discussion_r130762148
 
 

 ##########
 File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -377,7 +379,6 @@ boolean markAckForBatchMessage(BatchMessageIdImpl 
batchMessageId, AckType ackTyp
                 ackMessagesInEarlierBatch(batchMessageId, message);
             }
             if (log.isDebugEnabled()) {
-                int outstandingAcks = 
batchMessageAckTracker.get(message).cardinality();
 
 Review comment:
   yes, then I think we can just ignore for debug logs.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to