rdhabalia commented on a change in pull request #627: Reduce thread executor
pool sizes when running unit tests
URL: https://github.com/apache/incubator-pulsar/pull/627#discussion_r131003726
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -78,6 +78,16 @@
* Main class for Pulsar broker service
*/
public class PulsarService implements AutoCloseable {
+
+ private static final int EXECUTOR_THREAD_COUNT = Integer
+ .parseInt(System.getProperty("pulsar.executor-thread-count",
"20"));
Review comment:
> We might end up many executor sizes in the ServiceConfiguration and it
would be tricky to properly explain all of them
should we only add config for executors which are used in `BrokerService`
and `PulsarService` and rest of them we can keep default.??
> If the default is dependent on the number of cores, that might be tricky.
Ok. but I think if we define that default value in conf or hard-code here in
`Integer.parseInt(System.getProperty("pulsar.executor-thread-count", "20"))`,
both might be the same thing.??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
