Hi Dave,

Thanks for your detailed check.


However, I have not seen


> - rat check.

> Files missing headers: dependency-reduced-pom.xml which is generated.
> Please add an exclude to the pom.xml:
> 720d719
> <     <exclude>**/dependency-reduced-pom.xml</exclude>

by executing $mvn apache-rat:check in the src package.
Could you tell me the reproducing procedure?

Thanks,
Nozomi

________________________________
差出人: Dave Fisher <dave2w...@comcast.net>
送信日時: 2017年12月1日 8:37:50
宛先: dev@pulsar.incubator.apache.org
件名: Re: [VOTE] Pulsar 1.21.0-incubating Release Candidate 2

+1 (IPMC Binding)

Environment: macOS 10.12.6

Checked all signatures and check sums - SHA is 512 bits.

BIN distribution.
- NOTICE, README, LICENSE and DISCLAIMER.
——> Binary licenses are in a subdirectory and probably ought to be in the full 
LICENSE file. For next time IMHO.
- Started the standalone service - I’m not sure how well it worked, but had a 
lot of INFO log messages.

SRC distribution
- NOTICE. README, LICENSE and DISCLAIMER
- mvn install - all tests passed.
- rat check.
Files missing headers: dependency-reduced-pom.xml which is generated.
Please add an exclude to the pom.xml:
720d719
<     <exclude>**/dependency-reduced-pom.xml</exclude>

- Started the standalone service - looked similar to the bin results.

It is up to the Release Manager to decide to fix the exclude now and recut the 
release or wait until next release.
I also recommend removing the inactive license check plugin - 
license-maven-plugin

Regards,
Dave

On Nov 30, 2017, at 10:00 AM, Matteo Merli 
<matteo.me...@gmail.com<mailto:matteo.me...@gmail.com>> wrote:

+1 (binding)

Environment: MacOS 10.12

Checked:
* Signatures, crc
* Bin distribution:
    - NOTICE, README, LICENSE
    - Start standalone service and producer/consumer test
* Src distribution:
    - NOTICE,  README, LICENSE
    - Compile and unit tests
    - RAT check
    - Start standalone service
* Checked staging maven repository artifacts

Matteo


On Wed, Nov 29, 2017 at 9:57 PM Nozomi Kurihara 
<nkuri...@yahoo-corp.jp<mailto:nkuri...@yahoo-corp.jp>>
wrote:

This is the THIRD release candidate for Apache Pulsar, version
1.21.0-incubating.

It fixes the following issues:
https://github.com/apache/incubator-pulsar/milestone/10?closed=1

*** Please download, test and vote by December 5th 2017, 10:00 GMT.

Note that we are voting upon the source (tag), binaries are provided for
convenience.

Source and binary files:

https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-1.21.0-incubating-candidate-2/

Maven staging repo:
https://repository.apache.org/content/repositories/orgapachepulsar-1004/

The tag to be voted upon:
v1.21.0-incubating-candidate-2 (be96bd38b1f97b1b0888565196d77419004abe88)

https://github.com/apache/incubator-pulsar/releases/tag/v1.21.0-incubating-candidate-2

Pulsar's KEYS file containing PGP keys we use to sign the release:
https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS

Please download the the source package, and follow the README to build and
run the Pulsar standalone service.

Thanks,
Nozomi

--
Matteo Merli
<mme...@apache.org<mailto:mme...@apache.org>>

Reply via email to