[ https://issues.apache.org/jira/browse/QPID-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Gemmell closed QPID-1570. -------------------------------- Resolution: Won't Fix Fix Version/s: (was: Eclipse MC M5) The mentioned code was tidied up a little, but as per the comments above the functionality cant/wont be changed and is now only used for backwards compatibility.. > JMXConnectionFactory exception handling code is fragile > ------------------------------------------------------- > > Key: QPID-1570 > URL: https://issues.apache.org/jira/browse/QPID-1570 > Project: Qpid > Issue Type: Bug > Components: Java Management : CLI Tool, Java Management : JMX Console > Reporter: Aidan Skinner > > Split off from QPID-1522: > Rob Godfrey: > JMXConnectionFactory: > The code which looks at the exception text seems remarkable fragile to me... > At the very least I would expect some constants which could be shared with > the code that throws the exception. > Robbie Gemmell: > Hi Rob, > I wrote that bit originally. It is somewhat fragile, but unfortunately having > looked at the code that generates the exceptions i didnt think there was much > else i could do. The exception is generated by code within the optional JMXMP > addon (jmxremote_optional.jar) and just directly throws an IOException like > so: > throw new IOException("The server supported profiles " + > serverProfilesList + " do not " + > "match the client required profiles " + > clientProfilesList + "."); > so there are no constants to match against (though granted i should possibly > still have used constants for my own bit). > I have a secure RMI based JMX setup ready to go, so we can remove the > user-unfriendly/slightly-proprietary JMXMP stuff in future if desired (I know > Aidan wants to :P), and if so then that section of code should only really > ever be getting used for connecting to older brokers if they have used the > JMXMP based solution, which it seems that at the moment many dont, given how > guff the console was in that area. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org