Hello, Jonathan.
I made that change, if I remember correctly. Previously, the makefile in any of the examples directories was made by hand, and intended to be human-readable, to be deployed as part of the examples. Unfortunately, this way, the makefile was not in sync with the autotools world, and, for example, the compiler to be used, flags, library locations, were hardwired into the makefile to some extent. What we have now, as you said, is a autotools-generated makefile, to compile the examples in the build directory, and another one to be deployed (human-friendly) that also has to be capable of generating the examples, but using the installed distribution.

I don't know if this is the best approach. Of course, one of its problems is that you'll never be sure that the examples are going to build correctly once deployed. Anyway, be aware that moving the .libs/Makefile to the examples one is going to overwrite the autotools-generated one, and that doesn't seem a very clean approach.

--
Manuel.


Jonathan Robie escribió:
Nobody has objected so far. If I don't hear an objection, I'll go ahead and make that change.

Jonathan

Jonathan Robie wrote:
Each example in our examples directory currently has two Makefiles. One of these is a standard Autotools-generated Makefile located directly in the same directory as the source, and it always works because our builds break if it does not. Each example also has another Makefile called ./.libs/Makefile that is easy to read, and although it is also generated, the way that it is generated makes it look more like a hand-authored Makefile.

The ./libs/Makefile is fragile, because if someone changes one of the files used to generate it, the build is not affected. But it's also a lot easier to read, and much better to include in documentation.

Could we just put *that* Makefile into the directory for each example, so when that file breaks, whoever breaks it gets some feedback? We've had it break at least twice in one week recently, due to changes made by different people for different reasons.

Jonathan


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to