[ 
https://issues.apache.org/jira/browse/QPID-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Ritchie reassigned QPID-1768:
------------------------------------

    Assignee: Aidan Skinner  (was: Martin Ritchie)

Hi Aidan, can you review this change please.

> Priority Queue Flow to Disk is not thread safe.
> -----------------------------------------------
>
>                 Key: QPID-1768
>                 URL: https://issues.apache.org/jira/browse/QPID-1768
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Martin Ritchie
>            Assignee: Aidan Skinner
>            Priority: Blocker
>             Fix For: 0.5
>
>
> Following on from the FtD review  discussion documented here:
> http://cwiki.apache.org/confluence/display/qpid/FtD+Code+Review+Notes
> The changes to priority queue are not thread safe so cannot guarrantee 
> messages will be correctly kept in memory.
> This task includes:
> 19    0.5 H   _priorityListsindex.memoryUsed() + requriedSize is not 
> threadSafe. Currently hard to reason about.       
> 21    0.5 H   PriorityQueueEntryList add() not thread safe. Reclaiming memory 
> and then setting later is not atomic.    
> 24    0.5 H   setMemoryUsageMaximum / setMemoryUsageMinimum : not ThreadSafe 
> - synchronize     
> 17    0.5 H   Document atomicity of memory counting

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to