[ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749573#action_12749573 ]
Andrew Stitcher commented on QPID-1918: --------------------------------------- cpp/src/CMakeLists.txt: [Ignoring the spurious looking changes at the top] There is endless repetition of the following pattern: if (QPID_WINDOWS_STATIC) add_library (qpidcommon STATIC ${libqpidcommon_SOURCES}) else () add_library (qpidcommon SHARED ${libqpidcommon_SOURCES}) endif (QPID_WINDOWS_STATIC) Instead of doing this everywhere change it so that you define LIBRARY_LINKAGE to be STATIC or SHARED or somesuch at the top of the file just once and then do: add_library(qpidcommon ${LIBRARY_LINKAGE} ${libqpidcommon_SOURCES}) [Avoiding duplication is not restricted to actual code] > Patches/files for Windows QMF plug-in support > --------------------------------------------- > > Key: QPID-1918 > URL: https://issues.apache.org/jira/browse/QPID-1918 > Project: Qpid > Issue Type: New Feature > Components: Qpid Managment Framework > Environment: Windows XP SP3, VC++ 9.0 > Reporter: Pete MacKinnon > Assignee: Andrew Stitcher > Attachments: qpid-1918.patch > > > Various files for the Windows QMF plug-in support in cpp, based off revision: > 785848 > Need Static builds (release and debug) for correct runtime integration with > Condor: > src/broker.vcproj > src/client.vcproj > src/common.vcproj > src/qmfagent.vcproj > src/qmfconsole.vcproj > src/qpid.sln > src/qpidbroker.vcproj > - Changed to provide compile flags required for header file integration of > Posix types declared by both Qpid and Condor: > src/qpid/sys/windows/IntegerTypes.h > src/qpid/sys/windows/uuid.cpp > src/qpid/sys/windows/uuid.h > - Modified signature of PipeHandle ctor and fixed a Windows race condition in > the processing loop: > src/qpid/agent/ManagementAgentImpl.cpp > - Refactored the pipe code so that Condor can get a true socket fd it can > select on in daemon_core: > src/qpid/sys/Pipehandle.h > src/qpid/sys/posix/PipeHandle.cpp > src/qpid/sys/windows/PipeHandle.cpp > - Removed explicit dependency on Debug libs since we now have even more > targets. Added Apache license: > examples/qmf_agent.vcproj > - Added Apache license: > src/protocol_gen.mak > examples/qmf-agent/example_gen.mak > - Updated QMF Agent example README: > examples/README -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org