On Mon, 2009-09-21 at 16:39 +0100, Gordon Sim wrote: > On 09/17/2009 06:21 PM, Gordon Sim wrote: > > I don't mind how many Jiras we use to track the issues. I have created > > two already, but don't mind if those get augmented or replaced, > > providing we make the problems being solved clear. > > Carl, Kim, > > I have attached a candidate fix to QPID-2102 that also address > QPID-2101. Have a look and let me know what you think. If we are all > happy with this, I can commit it. Else we can keep seeking something > agreeable to all. > > --Gordon > The code looks good.
One question, however: I do not see isPersistent() in PersisbableMessage - this will be needed for setting the transient flag correctly when enqueuing on the store. Did you handle it another way (by casting, for example)? I'll make a separate checkin of the exchange route() refactorisation from the previous (subsequently rolled out) checkin 813825, which is a helpful change, but it is no longer needed for this issue. Kim --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
