Just wondered if there's any reason for removing the setLinkedException (did Rob mention this?)?
Marnie On Wed, Dec 2, 2009 at 1:48 AM, <ai...@apache.org> wrote: > Author: aidan > Date: Wed Dec 2 01:48:58 2009 > New Revision: 886031 > > URL: http://svn.apache.org/viewvc?rev=886031&view=rev > Log: > QPID-2192: remove extraneous printStackTrace()s > > Modified: > > > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java > > > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java > > > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java > > > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java > > > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java > > > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/state/StateWaiter.java > > > qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java > > Modified: > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java > URL: > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java?rev=886031&r1=886030&r2=886031&view=diff > > ============================================================================== > --- > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java > (original) > +++ > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java > Wed Dec 2 01:48:58 2009 > @@ -559,7 +559,6 @@ > if (connectionException.getCause() != null) > { > message = connectionException.getCause().getMessage(); > - connectionException.getCause().printStackTrace(); > } > else > { > > Modified: > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java > URL: > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java?rev=886031&r1=886030&r2=886031&view=diff > > ============================================================================== > --- > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java > (original) > +++ > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java > Wed Dec 2 01:48:58 2009 > @@ -1275,7 +1275,6 @@ > { > JMSException ex = new JMSException("Cannot create temporary > queue"); > ex.setLinkedException(e); > - e.printStackTrace(); > throw ex; > } > } > > Modified: > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java > URL: > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java?rev=886031&r1=886030&r2=886031&view=diff > > ============================================================================== > --- > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java > (original) > +++ > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java > Wed Dec 2 01:48:58 2009 > @@ -180,8 +180,6 @@ > catch (RuntimeException rte) > { > JMSException ex = new JMSException("Exception when sending > message"); > - rte.printStackTrace(); > - ex.setLinkedException(rte); > throw ex; > } > } > > Modified: > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java > URL: > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java?rev=886031&r1=886030&r2=886031&view=diff > > ============================================================================== > --- > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java > (original) > +++ > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java > Wed Dec 2 01:48:58 2009 > @@ -402,8 +402,6 @@ > } > catch (JMSException e) > { > - e.printStackTrace(); > - > throw new RuntimeException(e); > } > } > > Modified: > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java > URL: > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java?rev=886031&r1=886030&r2=886031&view=diff > > ============================================================================== > --- > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java > (original) > +++ > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java > Wed Dec 2 01:48:58 2009 > @@ -476,7 +476,6 @@ > } > catch (Exception e) > { > - e.printStackTrace(); > _logger.error("Exception processing frame", e); > propagateExceptionToFrameListeners(e); > exception(e); > > Modified: > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/state/StateWaiter.java > URL: > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/state/StateWaiter.java?rev=886031&r1=886030&r2=886031&view=diff > > ============================================================================== > --- > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/state/StateWaiter.java > (original) > +++ > qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/state/StateWaiter.java > Wed Dec 2 01:48:58 2009 > @@ -113,7 +113,6 @@ > { > _logger.error("Failover occured whilst waiting for states:" > + _awaitStates); > > - e.printStackTrace(); > return null; > } > } > > Modified: > qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java > URL: > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java?rev=886031&r1=886030&r2=886031&view=diff > > ============================================================================== > --- > qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java > (original) > +++ > qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java > Wed Dec 2 01:48:58 2009 > @@ -137,7 +137,6 @@ > } > catch (Throwable t) > { > - t.printStackTrace(); > if (!(shutdownBroken && > t instanceof SocketException && > t.getMessage().equalsIgnoreCase("socket closed") && > > > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:commits-subscr...@qpid.apache.org > >