[
https://issues.apache.org/jira/browse/QPID-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801936#action_12801936
]
Ian Main commented on QPID-1982:
--------------------------------
I agree it should be changed. If nothing else the entire thing should be
handled by the API. eg instead of setNotifyFd, we should be calling
notifyEngine() and it should do all the work of how to handle the queues etc.
Also in the wrapper we can have a waitForEvents(). This could still use the
unix pipe if that's appropriate, and I'm sure windows has a similar thing, but
it should all be hidden in the C++ regardless of the implementation.
> QMF ResilientConnection notifyFd feature portability
> ----------------------------------------------------
>
> Key: QPID-1982
> URL: https://issues.apache.org/jira/browse/QPID-1982
> Project: Qpid
> Issue Type: Improvement
> Components: Qpid Managment Framework
> Affects Versions: 0.5
> Environment: Windows
> Reporter: Steve Huston
>
> The QMF's C++ qmfcommon ResilientConnection class has a setNotifyFd (int fd)
> method. The docs say this can receive a file descriptor that is written on
> when certain events take place, supposedly so the other end of the channel
> can listen, select, etc. and be notified of some event.
> This construct isn't portable, both because of the datatype of the fd (int is
> not necessarily a legit handle type everywhere) and because the code assumes
> a write() will work. The code can be abstracted out to get rid of the write()
> easily enough, but what is the usage for this facility? There are no calls to
> setNotifyFd() that I can find outside of the library containing the
> implementation. So I can't tell if this is something that can be replaced by
> qpid::sys::PollableCondition or not.
> What is the use case for this, and how can we make this portable? Different
> IPC type? Callback to some private hook?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
