[ 
https://issues.apache.org/jira/browse/QPID-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828360#action_12828360
 ] 

Steve Huston commented on QPID-2371:
------------------------------------

Thanks for checking into this, Marcel. I'd rather not lock this in for every 
build. Can do please check where this is needed? If it's pervasive, please try 
this change to cpp/src/CMakeLists.txt instead:

Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt      (revision 905160)
+++ CMakeLists.txt      (working copy)
@@ -409,6 +409,9 @@
       /wd4800
       /wd4355
     )
+    if (MSVC80)
+      add_definitions(/D "_WIN32_WINNT=0x0501")
+    endif (MSVC80)
   endif (MSVC)
 
   set (qpidcommon_platform_SOURCES


> Missing includes for MSVC 2005 compiler
> ---------------------------------------
>
>                 Key: QPID-2371
>                 URL: https://issues.apache.org/jira/browse/QPID-2371
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker
>    Affects Versions: 0.6
>         Environment: MSVC 2005
>            Reporter: Marcel Roelofs
>            Assignee: Steve Huston
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: msvc2005.patch
>
>
> When compiling the 0.6 release candidate using MSVC 2005 I found some missing 
> header file includes that prevented qpid to compile out of the box. I'll add 
> a patch later.
> Also I had to add "/D _WIN32_WINNT=0x0501" to the compiler flags during cmake 
> makefile generation to prevent compile errors in various components, but I've 
> no idea how to add this to the cmake configuration. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Reply via email to