[ 
https://issues.apache.org/jira/browse/QPID-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834566#action_12834566
 ] 

Steve Huston commented on QPID-1842:
------------------------------------

I changed the Windows build to include the ACL sources in qpidbroker; this 
allows the broker to have ACL support on Windows, but restricts the 
acl-support-or-not decision to configure time (whether or not to include ACL is 
a cmake-build option).

I agree with Andrew that to move the ACL code back out to a separate plugin for 
Windows would best be accomplished by modifying the qmfgen'd code to build a 
separate list of files for the ACL support; that can be added to the acl plugin 
sources rather than building all the generated code into the qpidbroker library.

Windows change is in trunk at r910782

> QMF-generated code doesn't export symbols
> -----------------------------------------
>
>                 Key: QPID-1842
>                 URL: https://issues.apache.org/jira/browse/QPID-1842
>             Project: Qpid
>          Issue Type: Bug
>          Components: Qpid Managment Framework
>         Environment: Windows, Visual Studio
>            Reporter: Steve Huston
>
> The C++ ACL plugin fails to link on Windows because the needed QMF-generated 
> symbols built into the broker library are not exported.
> It is possible, with little trouble, to change the qmf-gen templates to 
> generate the proper export declarations; however, this would cause all 
> generated symbols to be exported, not just the ACL-related ones. This is not 
> necessarily a bad thing, but I'm open to more ideas on how to accomplish this.
> The wide-ranging nature of the code gen was hinted at in QPID-1274. So that's 
> possibly something to consider.
> If I don't hear objections within a day or two, I'll go ahead and add the 
> exports to all generated symbols.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to