[
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850870#action_12850870
]
Robbie Gemmell commented on QPID-2360:
--------------------------------------
The configuration changes dont fully account for the Security configuration,
particularly the ability to reload the security configuration at runtime (eg to
update the Firewall configuration).
ServerConfiguration.reparseConfigFIleSecuritySections() expects the virtualhost
configuration properties to be part of the main configuration, which is not the
case now when an external virtualhosts configuration file is used.
As such this needs updated to determine whether an external file was used to
configure the virtualhost such that the configuration sections are properly
reparsed. This is not detected by the firewall related unit/system tests in
ServerConfiguration and FirewallConfigTest, as some utilise only broker level
security configuration, and the others utilise virtualhost level configuration
but when the main config is reparsed and the virtualhosts file isnt, it will
return an empty subset of virtualhost security and the firewall will then deny
by default, which is what the tests expect to occur and so no problem is found.
The updated (trunk) patch contains a number of .orig files, presumably from
'unclean' patch runs. It also still contains some seemingly unrelated
modifications (eg in AlertingTest, which now fails when run). If these are
unrelated but still required changes, a new JIRA should be raised for them to
allow proper tracking of the issue.
> declaring virtualhost level firewall configuration in virtualhosts.xml leads
> to NPE on startup
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch,
> 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads
> to NPE on startup.
> After moving the same configuration into config.xml the broker then loads ok
> and the configuration works as expected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
