I don't have any current plans to look at it, so ill exclude it tomorrow (can't be bothered firing up the dev env just now, enough of this computer lark for tonight... time for Lost :P)
Robbie > -----Original Message----- > From: Rajith Attapattu [mailto:rajit...@gmail.com] > Sent: 31 March 2010 19:57 > To: dev@qpid.apache.org > Subject: Re: svn commit: r926829 - > /qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/clien > t/message/JMSDestinationTest.java > > We could temporarily exclude until the issue is fixed. > If you are going to check in a fix soon, I'd say don't bother. > > Rajith > > On Wed, Mar 31, 2010 at 2:54 PM, Robbie Gemmell > <robbie.gemm...@gmail.com> wrote: > > This new test fails on all the Java test profiles other than > java.0.10. Is it ok to exclude it from these? > > > > Regards, > > Robbie > > > >> -----Original Message----- > >> From: raj...@apache.org [mailto:raj...@apache.org] > >> Sent: 23 March 2010 22:48 > >> To: comm...@qpid.apache.org > >> Subject: svn commit: r926829 - > >> > /qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/clien > >> t/message/JMSDestinationTest.java > >> > >> Author: rajith > >> Date: Tue Mar 23 22:48:23 2010 > >> New Revision: 926829 > >> > >> URL: http://svn.apache.org/viewvc?rev=926829&view=rev > >> Log: > >> Added test case for QPID-2242 using a custom exchange to verify the > >> fix. > >> > >> Modified: > >> > >> > qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/client > >> /message/JMSDestinationTest.java > >> > >> Modified: > >> > qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/client > >> /message/JMSDestinationTest.java > >> URL: > >> > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/systests/src/main/jav > >> > a/org/apache/qpid/test/client/message/JMSDestinationTest.java?rev=92682 > >> 9&r1=926828&r2=926829&view=diff > >> > ======================================================================= > >> ======= > >> --- > >> > qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/client > >> /message/JMSDestinationTest.java (original) > >> +++ > >> > qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/client > >> /message/JMSDestinationTest.java Tue Mar 23 22:48:23 2010 > >> @@ -21,9 +21,11 @@ > >> package org.apache.qpid.test.client.message; > >> > >> import org.apache.qpid.configuration.ClientProperties; > >> +import org.apache.qpid.client.AMQAnyDestination; > >> import org.apache.qpid.client.AMQDestination; > >> import org.apache.qpid.client.AMQTopic; > >> import org.apache.qpid.client.CustomJMSXProperty; > >> +import org.apache.qpid.framing.AMQShortString; > >> import org.apache.qpid.management.common.mbeans.ManagedQueue; > >> import org.apache.qpid.test.utils.JMXTestUtils; > >> import org.apache.qpid.test.utils.QpidTestCase; > >> @@ -327,4 +329,45 @@ public class JMSDestinationTest extends > >> > >> } > >> > >> + /** > >> + * Send a message to a custom exchange and then verify > >> + * the message received has the proper destination set > >> + * > >> + * @throws Exception > >> + */ > >> + public void testGetDestinationWithCustomExchange() throws > >> Exception > >> + { > >> + > >> + AMQDestination dest = new AMQAnyDestination(new > >> AMQShortString("my-exchange"), > >> + new > >> AMQShortString("direct"), > >> + new > >> AMQShortString("test"), > >> + false, > >> + false, > >> + new > >> AMQShortString("test"), > >> + false, > >> + new > >> AMQShortString[]{new AMQShortString("test")}); > >> + > >> + // to force the creation of my-exchange. > >> + sendMessage(_session, dest, 1); > >> + > >> + MessageProducer prod = _session.createProducer(dest); > >> + > >> + MessageConsumer consumer = _session.createConsumer(dest); > >> + > >> + _connection.start(); > >> + > >> + sendMessage(_session, dest, 1); > >> + > >> + Message message = consumer.receive(10000); > >> + > >> + assertNotNull("Message should not be null", message); > >> + > >> + Destination destination = message.getJMSDestination(); > >> + > >> + assertNotNull("JMSDestination should not be null", > >> destination); > >> + > >> + assertEquals("Incorrect Destination name", "my-exchange", > >> dest.getExchangeName().asString()); > >> + assertEquals("Incorrect Destination type", "direct", > >> dest.getExchangeClass().asString()); > >> + assertEquals("Incorrect Routing Key", "test", > >> dest.getRoutingKey().asString()); > >> + } > >> } > >> > >> > >> > >> -------------------------------------------------------------------- > - > >> Apache Qpid - AMQP Messaging Implementation > >> Project: http://qpid.apache.org > >> Use/Interact: mailto:commits-subscr...@qpid.apache.org > > > > > > > > --------------------------------------------------------------------- > > Apache Qpid - AMQP Messaging Implementation > > Project: http://qpid.apache.org > > Use/Interact: mailto:dev-subscr...@qpid.apache.org > > > > > > > > -- > Regards, > > Rajith Attapattu > Red Hat > http://rajith.2rlabs.com/ > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:dev-subscr...@qpid.apache.org --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
