[ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871162#action_12871162 ]
Robbie Gemmell commented on QPID-2606: -------------------------------------- Ive started taking a look at this, but I notice in the patch that a couple of the files are entirely replaced for apparently small changea - the line endings on the files are not set to native in the repo. Ive set the native line endings property on the files, could you generate the patch again to pick up the changes. There is alsothe odd //TODO in there alongside new code, seems like they should have been completed by now: if they havent then id recommend doing so, or if they have been then remove the comments :) > Clarify/identify where ACL permission should be applied in the broker > ---------------------------------------------------------------------- > > Key: QPID-2606 > URL: https://issues.apache.org/jira/browse/QPID-2606 > Project: Qpid > Issue Type: Sub-task > Reporter: Andrew Kennedy > Assignee: Robbie Gemmell > Attachments: > 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, > 0019-QPID-2606-Added-AMQSecurityException.patch, > 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org