[
https://issues.apache.org/jira/browse/QPID-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879518#action_12879518
]
Steve Huston commented on QPID-2519:
------------------------------------
I reviewed the patch quickly and have a few requests:
1. Please reformat according to Qpid coding style
(http://qpid.apache.org/qpid-c-documentation.html) - no tabs, consistent brace
style
2. There's a global WinService in QpiddBroker.cpp - what's that for?
3. Lots of printfs and no Qpid logging statements, and no exception throwing on
error. Please review these and probably should be throwing on errors; outputs
should probably be using logging to be redirected as the user specified.
> Allow Windows Broker to run as a Service
> ----------------------------------------
>
> Key: QPID-2519
> URL: https://issues.apache.org/jira/browse/QPID-2519
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker
> Reporter: Kerry Bonin
> Attachments: broker_as_service_r921371.patch
>
>
> The Windows version of the C++ Broker should have the ability to run as a
> Windows Service, to correspond with the ability of the *nix version to run as
> a daemon, as this is a common requirement for critical software
> infrastructure elements of enterprise class software on the Windows platform.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
