[
https://issues.apache.org/jira/browse/QPID-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883705#action_12883705
]
Steve Huston commented on QPID-2708:
------------------------------------
The patch looks good, with the exception of small issues:
- In qpid/cpp/include/qpid/types/ImportExport.h the
#if defined(CLIENT_EXPORT) || defined (qpidtypes_EXPORTS)
should be
#if defined(TYPES_EXPORT) || defined (qpidtypes_EXPORTS)
- In qpid/cpp/src/CMakeLists.txt are you sure that this is correct:
target_link_libraries(qpidtypes uuid ${qpidtypes_platform_LIBS})
I didn't think uuid was portable. Maybe it should be in the POSIX/Linux section?
> Separate types library from common library.
> -------------------------------------------
>
> Key: QPID-2708
> URL: https://issues.apache.org/jira/browse/QPID-2708
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Minor
> Attachments: libqpidtypes.patch
>
>
> Symbols from the qpid::types namespace are currently bundled into the common
> library.
> Create a new types library for these symbols, in order to
> - make it consistent with our convention of creating a library per namespace.
> - make the qpid ABI clear: it consists only of symbols in the messaging +
> types libraries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
