kgiusti commented on a change in pull request #1324:
URL: https://github.com/apache/qpid-dispatch/pull/1324#discussion_r676864664
##########
File path: src/adaptors/http2/http2_adaptor.c
##########
@@ -625,15 +625,17 @@ static int snd_data_callback(nghttp2_session *session,
// Insert the framehd of length 9 bytes into the buffer
memcpy(qd_http2_buffer_cursor(http2_buff), framehd,
HTTP2_DATA_FRAME_HEADER_LENGTH);
qd_http2_buffer_insert(http2_buff, HTTP2_DATA_FRAME_HEADER_LENGTH);
- pn_raw_buffer_t pn_raw_buffs[stream_data->qd_buffers_to_send];
- int written =
qd_message_stream_data_buffers(stream_data->curr_stream_data, pn_raw_buffs,
stream_data->curr_stream_data_qd_buff_offset, stream_data->qd_buffers_to_send);
+
+ size_t diff =
qd_message_stream_data_buffer_count(stream_data->curr_stream_data) -
stream_data->curr_stream_data_qd_buff_offset;
+ pn_raw_buffer_t pn_raw_buffs[diff];
Review comment:
I thought we're avoiding VLA's, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
