jiridanek commented on a change in pull request #1322:
URL: https://github.com/apache/qpid-dispatch/pull/1322#discussion_r677205347
##########
File path: .github/workflows/build.yaml
##########
@@ -173,7 +173,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04]
- buildType: [RelWithDebInfo]
+ buildType: [Debug]
Review comment:
Using a Debug build makes the CI run maybe ~1 minute longer ;P Users are
not running debug builds in production, therefore it would make sense to me to
test mostly with RelWithDebInfo.
I think there should be maybe one debug build in the CI, not all of them.
BTW, Coverity warns if there are C asserts that have side-effects, so I presume
debug builds only serve to introduce some timing randomness into tests...
##########
File path: .github/workflows/build.yaml
##########
@@ -378,14 +378,22 @@ jobs:
- name: Display ccache stats
run: ccache -s
+ - name: enable asserts on asan build
+ if: matrix.runtimeCheck == 'asan' || matrix.runtimeCheck == 'OFF'
+ run: echo "DispatchCMakeAsserts=ON" >> $GITHUB_ENV
+
+ - name: disable asserts on tsan build
+ if: matrix.runtimeCheck == 'tsan'
+ run: echo "DispatchCMakeAsserts=OFF" >> $GITHUB_ENV
Review comment:
This does not work. Debug builds always have asserts enabled;
`-DQD_ENABLE_ASSERTIONS` is only a way to turn them on where they would be
otherwise disabled.
Notice that on Debug builds, the option does not undefine anything (which
would be necessary to disable asserts):
https://github.com/apache/qpid-dispatch/blob/main/CMakeLists.txt#L218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
