DreamPearl commented on a change in pull request #319:
URL: https://github.com/apache/qpid-proton/pull/319#discussion_r691207260



##########
File path: cpp/src/messaging_adapter.cpp
##########
@@ -48,6 +48,8 @@
 
 #include <assert.h>
 
+#include <proton/tracing.hpp>

Review comment:
       Done, now looks like the dummy file is linking correctly!
   
   Now build is passing and I've also checked for when opentelemetry is not 
present by skipping otel build steps in gha build.

##########
File path: .github/workflows/build.yml
##########
@@ -4,6 +4,7 @@ on: [push, pull_request]
 
 jobs:
   build:
+    if: github.repository == 'DreamPearl/qpid-proton'

Review comment:
       ack!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to