jiridanek commented on a change in pull request #1: URL: https://github.com/apache/qpid-protonj2/pull/1#discussion_r695154458
########## File path: protonj2/src/main/java/org/apache/qpid/protonj2/buffer/ProtonBuffer.java ########## @@ -1220,7 +1220,7 @@ * {@code src.capacity}, or * if {@code length} is greater than {@code this.writableBytes} */ - ProtonBuffer writeBytes(ProtonBuffer source, int sourrceIndex, int length); + ProtonBuffer writeBytes(ProtonBuffer source, int sourceIndex, int length); // TODO rename to offset as in overrides? Review comment: But do you think the rename is worth a separate Jira, or should I just fix the spelling error and move on? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org