[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432292#comment-17432292 ]
ASF GitHub Bot commented on DISPATCH-1956: ------------------------------------------ codecov-commenter commented on pull request #1391: URL: https://github.com/apache/qpid-dispatch/pull/1391#issuecomment-948393100 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1391?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1391](https://codecov.io/gh/apache/qpid-dispatch/pull/1391?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4867185) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/94164788cebf38d28b4213f5977cac1d62933ad4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9416478) will **increase** coverage by `0.04%`. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/graphs/tree.svg?width=650&height=150&src=pr&token=rk2Cgd27pP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/qpid-dispatch/pull/1391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #1391 +/- ## ========================================== + Coverage 84.61% 84.66% +0.04% ========================================== Files 114 114 Lines 28436 28441 +5 ========================================== + Hits 24061 24079 +18 + Misses 4375 4362 -13 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/log.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2xvZy5j) | `91.50% <100.00%> (+0.09%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.95% <0.00%> (-0.22%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.45% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.56% <0.00%> (+0.01%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.55% <0.00%> (+0.06%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.36% <0.00%> (+0.21%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.71% <0.00%> (+0.28%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `94.08% <0.00%> (+0.73%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `87.00% <0.00%> (+0.95%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1391?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1391?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9416478...4867185](https://codecov.io/gh/apache/qpid-dispatch/pull/1391?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > log.c rewrite to reduce locking scope > ------------------------------------- > > Key: DISPATCH-1956 > URL: https://issues.apache.org/jira/browse/DISPATCH-1956 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node > Affects Versions: 1.15.0 > Reporter: Ken Giusti > Assignee: michael goulish > Priority: Major > Labels: deadlock, tsan > Fix For: 1.18.0 > > Attachments: tsan.supp > > > {noformat} > WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) > (pid=1474955) > Cycle in lock order graph: M11 (0x7b10000002c0) => M9 (0x7b1000000240) => > M11 > > Mutex M9 acquired here while holding mutex M11 in main thread: > #0 pthread_mutex_lock <null> (libtsan.so.0+0x528ac) > #1 sys_mutex_lock > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57 > (libqpid-dispatch.so+0x8cb7d) > #2 push_event > /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:63 > (libqpid-dispatch.so+0x6fa13) > #3 qd_entity_cache_add > /home/kgiusti/work/dispatch/qpid-dispatch/src/entity_cache.c:69 > (libqpid-dispatch.so+0x6fc26) > #4 qd_alloc_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:302 > (libqpid-dispatch.so+0x5878b) > #5 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:318 > (libqpid-dispatch.so+0x5878b) > #6 new_qd_log_entry_t /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:61 > (libqpid-dispatch.so+0x75891) > #7 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:426 > (libqpid-dispatch.so+0x76205) > #8 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453 > (libqpid-dispatch.so+0x76580) > #9 qd_python_log > /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547 > (libqpid-dispatch.so+0x8d1cb) > #10 <null> <null> (libpython3.8.so.1.0+0x12a23b) > #11 main_process > /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95 > (qdrouterd+0x40281c) > #12 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367 > (qdrouterd+0x4024fc) > > Hint: use TSAN_OPTIONS=second_deadlock_stack=1 to get more informative > warning message > > Mutex M11 acquired here while holding mutex M9 in main thread: > #0 pthread_mutex_lock <null> (libtsan.so.0+0x528ac) > #1 sys_mutex_lock > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57 > (libqpid-dispatch.so+0x8cb7d) > #2 qd_vlog_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:425 > (libqpid-dispatch.so+0x76200) > #3 qd_log_impl /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:453 > (libqpid-dispatch.so+0x76580) > #4 qd_python_log > /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:547 > (libqpid-dispatch.so+0x8d1cb) > #5 <null> <null> (libpython3.8.so.1.0+0x12a23b) > #6 main_process > /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95 > (qdrouterd+0x40281c) > #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367 > (qdrouterd+0x4024fc) > > SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) > (/lib64/libtsan.so.0+0x528ac) in __interceptor_pthread_mutex_lock > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org