[ https://issues.apache.org/jira/browse/QPIDJMS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434421#comment-17434421 ]
ASF GitHub Bot commented on QPIDJMS-552: ---------------------------------------- franz1981 commented on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-952051837 There're still something to be considered while using this processing model in case JMS Sessions are used on different threads AND share the same connection: - on `main` the Netty thread handling the shared connection issue completion events vs exclusive single threaded thread pools - on this PR the Netty thread handling the shared connection issue completion events vs a shared thread pool If the completions event processing is heavy weight, issuing completion events vs a shared thread pool shouldn't be the bottleneck, but each completion thread processing, while if completion event processing is light-weight, reusing the same completion thread(s), kept busy as much as possible, reduce the amount of context switches and native resources used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > JMS 2 Completion threads shouldn't scale with the number of sessions > -------------------------------------------------------------------- > > Key: QPIDJMS-552 > URL: https://issues.apache.org/jira/browse/QPIDJMS-552 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client > Affects Versions: 1.3.0 > Reporter: Francesco Nigro > Priority: Major > > JMS 2 Completion threads are now tied to be one per JMS Session ie a client > application with N JMS sessions need N completion threads to handle the > completion events. > Given that the asynchronous model of JMS 2 allows users to have few threads > handling many JMS sessions, should be better to reduce the amount of > completion threads without exceeding the number of available cores and > shrink/grow according to the completion event processing load. > If the user confine a connection in a thread handling many JMS sessions and > the completion events are issued by the same Netty thread in sequence, if the > completion processing for a JMS Session is fast enough, next JMS Sessions can > reuse existing completion threads instead of using a new one. > This model save using too many completion threads for users tasks that are > supposed to be very fast: if the user task cause a specific JMS Session > completion thread to block, the expectation is that the system should be able > to create a new completion thread to handle other JMS Session completion > events, as expected. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org