ted-ross commented on pull request #1416: URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-958124314
> > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS non-configurable? IOW, get rid of the flag and just always provide memory statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part of our CI. > > Just an opinion, thoughts? > > I am all for getting rid of the flag once and for all and always provide memory statistics but first I want to understand why this flag was introduced in the first place ? If we decide to keep this flag, we need to augment CI (preferably GHA) to test with QD_MEMORY_STATS=OFF. That will add _yet another_ build type to the already long list of tests we run, so I am inclined to say let's just get rid of this flag. > > @ted-ross what do you think ? +1 on removing the flag. This was first introduced due to concern that the stats collection might be costly. I don't believe that it has been identified as a performance/memory bottleneck in any of the investigations we've done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
