[ 
https://issues.apache.org/jira/browse/DISPATCH-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439414#comment-17439414
 ] 

ASF GitHub Bot commented on DISPATCH-2103:
------------------------------------------

jiridanek opened a new pull request #1425:
URL: https://github.com/apache/qpid-dispatch/pull/1425


   Unit tests and related changes for the log message amount to much of the 
bulk of this commit.
   
   * Old g++ (RHEL 7) does not properly implement regexes
   * On Ubuntu and rarely Fedora, and all other modern Linuxes, the 
qd_lws_listener_free is sometimes not called in my test. This is resolved with 
the .finalize, available only in LibWebSockets 3.1 (RHEL 7 has version 3.0.1)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Log the actual HTTP websocket listener port when 0 was specified in config
> --------------------------------------------------------------------------
>
>                 Key: DISPATCH-2103
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2103
>             Project: Qpid Dispatch
>          Issue Type: New Feature
>    Affects Versions: 1.15.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>             Fix For: 1.19.0
>
>
> {code}
>     if (hl->vhost) {
>         /* Store hl pointer in vhost */
>         void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, &protocols[0], 
> sizeof(hl));
>         memcpy(vp, &hl, sizeof(hl));
>         qd_log(hs->log, QD_LOG_NOTICE, "Listening for HTTP on %s", 
> config->host_port);
>         return;
>     } else {
>         qd_log(hs->log, QD_LOG_NOTICE, "Error listening for HTTP on %s", 
> config->host_port);
>         goto error;
>     }
>     return;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to