mklaca commented on a change in pull request #113: URL: https://github.com/apache/qpid-broker-j/pull/113#discussion_r743745075
########## File path: broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/AclRulePredicatesBuilder.java ########## @@ -123,6 +123,16 @@ else if (property == Property.ATTRIBUTES) { _attributeNames.addAll(splitToSet(value)); } + else if (property == Property.CONNECTION_LIMIT) + { + LOGGER.warn("The ACL Rule property 'connection_limit' has been deprecated"); Review comment: I changed the message to be precise. ########## File path: broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/AclRulePredicatesBuilder.java ########## @@ -123,6 +123,16 @@ else if (property == Property.ATTRIBUTES) { _attributeNames.addAll(splitToSet(value)); } + else if (property == Property.CONNECTION_LIMIT) + { + LOGGER.warn("The ACL Rule property 'connection_limit' has been deprecated"); + return false; + } + else if (property == Property.CONNECTION_FREQUENCY_LIMIT) + { + LOGGER.warn("The ACL Rule property 'connection_frequency_limit' has been deprecated"); Review comment: I changed the message to be precise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org