jiridanek commented on a change in pull request #340:
URL: https://github.com/apache/qpid-proton/pull/340#discussion_r744534838
##########
File path: cpp/src/uuid.cpp
##########
@@ -42,15 +44,17 @@ namespace {
// Seed the random number generated once at startup.
struct seed {
Review comment:
Threadsafety, I almost forgot! The std:: random stuff is not threadsafe,
so maybe it should be declared thread_local as that would be easiest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
