[
https://issues.apache.org/jira/browse/QPID-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891217#action_12891217
]
Martin Ritchie commented on QPID-2155:
--------------------------------------
Review feedback
List of actions:
1. Remove the following redundant code at QCRA Line 920, as it is effectively
an if(false):
// Bail out early if there is a problem with the file
if (new File(testFileName) == null
new File(testFileName + COMPRESS_EXTENSION) == null)
{ return index; }
2. Move the integer filename discriminator before the date pattern stamp when
using CountDirection = 0, updating the rollFile() and countFileIndex() methods
accordingly to allow always identifying the next available number and deleting
the old files in accordance with the defined MaxSizeRolledBackups limit.
[ Show ยป ]
Robbie Gemmell added a comment - 05/Feb/10 09:43 AM List of actions: 1. Remove
the following redundant code at QCRA Line 920, as it is effectively an
if(false): // Bail out early if there is a problem with the file if (new
File(testFileName) == null
new File(testFileName + COMPRESS_EXTENSION) == null)
{ return index; } 2. Move the integer filename discriminator before the date
pattern stamp when using CountDirection = 0, updating the rollFile() and
countFileIndex() methods accordingly to allow always identifying the next
available number and deleting the old files in accordance with the defined
MaxSizeRolledBackups limit.
> QpidRollingFileAppender has no tests and does not appear to work.
> -----------------------------------------------------------------
>
> Key: QPID-2155
> URL: https://issues.apache.org/jira/browse/QPID-2155
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.5
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: 0.6
>
>
> When investigating QPID-2085 the following issues were found:
> The QpidRollingFileAppender does not appear to behave as expected from the
> configuration.
> Have noticed the following:
> - qpid.log being archived shortly after creation, resulting in no log file
> for the broker. (When using StaticName)
> - Log files being archived before 10MB setting, using default configuration.
> - Log files index not being used as described in the comments. file .0 is
> always the current head of the log rather than 'n' as described.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
