[ https://issues.apache.org/jira/browse/QPID-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443449#comment-17443449 ]
ASF subversion and git services commented on QPID-8565: ------------------------------------------------------- Commit 0ecc652fb6767b6a48a3b3018cf2f88e405ad015 in qpid-broker-j's branch refs/heads/main from Marek Laca [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=0ecc652 ] QPID-8565: [Broker-J] Enhancement of ACL rule predicates evaluation This closes #113 > [Broker-J] Enhancement of ACL rule predicates evaluation > -------------------------------------------------------- > > Key: QPID-8565 > URL: https://issues.apache.org/jira/browse/QPID-8565 > Project: Qpid > Issue Type: Improvement > Components: Broker-J > Reporter: Marek Laca > Priority: Minor > Labels: Broker, Java > > The access control plugin checks the rights of the user to perform an action > on the broker's component. The access control plugin iterates through the ACL > rules and checks their predicates. The user action is denied or allowed based > on the test result. > The aim of this task are refactoring of the code that is required for the > [QPID-8487|https://issues.apache.org/jira/browse/QPID-8487] and > [QPID-8488|https://issues.apache.org/jira/browse/QPID-8488], improving the > test of the ACL rule predicates and removing useless classes. Changes should > not have any impact on the functionality of the access control plugin. > The ObjectProperties class has two responsibilities, it holds the rule > predicates and also the objects properties that are checked. The > responsibilities of ObjectProperties class should be split because the code > should honor the principle of one responsibility per class. > The Rule class is treated as immutable but the immutability is not enforce by > the code. > The Action, AclAction and ClientAction classes are only data holders that > don't have any real responsibility. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org