[
https://issues.apache.org/jira/browse/PROTON-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451201#comment-17451201
]
ASF GitHub Bot commented on PROTON-2406:
----------------------------------------
astitcher commented on pull request #337:
URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-982761885
This change looks good.
However the commit comment doesn't include the JIRA reference.
Please edit the commit message and I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Use of reconnect_options::failover_urls triggers
> -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: PROTON-2406
> URL: https://issues.apache.org/jira/browse/PROTON-2406
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding, examples
> Affects Versions: proton-c-0.36.0
> Reporter: Jiri Daněk
> Assignee: Rakhi Kumari
> Priority: Minor
> Fix For: proton-c-0.37.0
>
>
> {noformat}
> [ 56%] Building CXX object
> CMakeFiles/reconnect_client.dir/reconnect_client.cpp.o
> /usr/share/proton/examples/cpp/reconnect_client.cpp: In member function
> ‘virtual void reconnect_client::on_container_start(proton::container&)’:
> /usr/share/proton/examples/cpp/reconnect_client.cpp:59:35: warning:
> ‘proton::reconnect_options& proton::reconnect_options::failover_urls(const
> std::vector<std::basic_string<char> >&)’ is deprecated (declared at
> /usr/include/proton/reconnect_options.hpp:82): use
> connection_options::failover_urls() [-Wdeprecated-declarations]
> ro.failover_urls(failovers);
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
