ganeshmurthy commented on a change in pull request #1413: URL: https://github.com/apache/qpid-dispatch/pull/1413#discussion_r764969413
########## File path: include/qpid/dispatch/internal/export.h ########## @@ -0,0 +1,27 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, +* software distributed under the License is distributed on an +* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +* KIND, either express or implied. See the License for the +* specific language governing permissions and limitations +* under the License. +*/ + +/// @cond INTERNAL + +/// import/export macros +#if defined(_WIN32) +# define QD_EXPORT __declspec(dllexport) +#else +# define QD_EXPORT __attribute__((visibility("default"))) __attribute__((used)) Review comment: I was looking at this - https://developer.arm.com/documentation/dui0491/f/Compiler-specific-Features/--attribute----used---function-attribute?lang=en It seems to say that "This function attribute informs the compiler that a static function is to be retained in the object file, even if it is unreferenced." Is it true that __attribute__((used)) can *only* be used on *static* functions ? I also understand from reading this - https://developer.arm.com/documentation/dui0491/f/BABCJJID - that __attribute__((used)) can also be used with *static* variables, although I understand that this PR is not attempting to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
