ganeshmurthy commented on a change in pull request #1452: URL: https://github.com/apache/qpid-dispatch/pull/1452#discussion_r768889840
########## File path: src/parse.c ########## @@ -23,27 +23,37 @@ #include "qpid/dispatch/amqp.h" #include "qpid/dispatch/ctools.h" +#include "buffer_field_api.h" + #include <assert.h> #include <inttypes.h> #include <stdio.h> DEQ_DECLARE(qd_parsed_field_t, qd_parsed_field_list_t); + +typedef struct qd_amqp_field_t { Review comment: I am thinking aloud here but can qd_amqp_field_t and qd_buffer_field_t just be combined into just a qd_amqp_field_t ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org