[
https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463869#comment-17463869
] ASF GitHub Bot commented on PROTON-2308: ---------------------------------------- codecov-commenter edited a comment on pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#issuecomment-995011027 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#346](https://codecov.io/gh/apache/qpid-proton/pull/346?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b020661) into [main](https://codecov.io/gh/apache/qpid-proton/commit/996b9b114fdb4682c8114ad700705446ff3a24fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (996b9b1) will **increase** coverage by `20.12%`. > The diff coverage is `n/a`. > :exclamation: Current head b020661 differs from pull request most recent head 08c96c7. Consider uploading reports for the commit 08c96c7 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #346 +/- ## =========================================== + Coverage 68.22% 88.34% +20.12% =========================================== Files 356 47 -309 Lines 73060 2394 -70666 =========================================== - Hits 49843 2115 -47728 + Misses 23217 279 -22938 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | | | | [cpp/include/proton/terminus.hpp](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3Rlcm1pbnVzLmhwcA==) | | | | [cpp/src/link\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9saW5rX3Rlc3QuY3Bw) | | | | [cpp/src/node\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9ub2RlX29wdGlvbnMuY3Bw) | | | | [cpp/src/terminus.cpp](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy90ZXJtaW51cy5jcHA=) | | | | [python/proton/\_\_init\_\_.py](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fX2luaXRfXy5weQ==) | | | | [c/tests/fuzz/fuzz-message-decode.c](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9mdXp6L2Z1enotbWVzc2FnZS1kZWNvZGUuYw==) | | | | [c/tests/ssl\_proactor\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9zc2xfcHJvYWN0b3JfdGVzdC5jcHA=) | | | | [c/src/core/util.c](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS91dGlsLmM=) | | | | [c/tests/data\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9kYXRhX3Rlc3QuY3Bw) | | | | ... and [299 more](https://codecov.io/gh/apache/qpid-proton/pull/346/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/346?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/346?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [996b9b1...08c96c7](https://codecov.io/gh/apache/qpid-proton/pull/346?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > [cpp] Add support for setting Dynamic Node Properties > ----------------------------------------------------- > > Key: PROTON-2308 > URL: https://issues.apache.org/jira/browse/PROTON-2308 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding > Affects Versions: proton-c-0.33.0 > Reporter: James Henry > Assignee: Rakhi Kumari > Priority: Major > Labels: api-addition > > Requesting support for setting the dynamic node properties be added to the > source and target options. > This would allow the setting of termini node properties for senders and > receivers. > Similar to the following request made for Python here: > https://issues.apache.org/jira/browse/PROTON-816 -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
