jiridanek commented on a change in pull request #1468: URL: https://github.com/apache/qpid-dispatch/pull/1468#discussion_r774096309
########## File path: cmake/FindLibWebSockets.cmake ########## @@ -45,10 +45,11 @@ find_path(LIBWEBSOCKETS_INCLUDE_DIRS PATHS "/usr/include" ) +# strips trailing version elaboration, e.g. #define LWS_LIBRARY_VERSION "4.1.6-git..." if(LIBWEBSOCKETS_INCLUDE_DIRS AND EXISTS "${LIBWEBSOCKETS_INCLUDE_DIRS}/lws_config.h") file(STRINGS "${LIBWEBSOCKETS_INCLUDE_DIRS}/lws_config.h" lws_version_str REGEX "^#define[ \t]+LWS_LIBRARY_VERSION[ \t]+\"[^\"]+\"") - string(REGEX REPLACE "^#define[ \t]+LWS_LIBRARY_VERSION[ \t]+\"([^\"]+)\".*" "\\1" + string(REGEX REPLACE "^#define[ \t]+LWS_LIBRARY_VERSION[ \t]+\"([0-9.]+).*" "\\1" Review comment: This is the cause that the test was not being run on CentOS 7. There, the `LWS_LIBRARY_VERSION` ended up being `3.0.1-`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org