[ 
https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471077#comment-17471077
 ] 

ASF GitHub Bot commented on PROTON-2308:
----------------------------------------

astitcher commented on a change in pull request #352:
URL: https://github.com/apache/qpid-proton/pull/352#discussion_r780256333



##########
File path: cpp/include/proton/terminus.hpp
##########
@@ -99,14 +102,15 @@ class terminus {
 
     /// Obtain a reference to the AMQP dynamic node properties for the
     /// terminus.  See also lifetime_policy.
+    /// @deprecated in favor of dynamic_properties()??
     PN_CPP_EXTERN value node_properties() const;
 
-    /// Extension capabilities that are supported/requested
+    /// **Unsettled API** Extension capabilities that are supported/requested
     PN_CPP_EXTERN std::vector<symbol> capabilities() const;
 
-    /// Obtain the AMQP dynamic node properties for the
+    /// **Unsettled API** Obtain the AMQP dynamic node properties for the
     /// terminus as a standard map.

Review comment:
       Good catch




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [cpp] Add support for setting Dynamic Node Properties
> -----------------------------------------------------
>
>                 Key: PROTON-2308
>                 URL: https://issues.apache.org/jira/browse/PROTON-2308
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>    Affects Versions: proton-c-0.33.0
>            Reporter: James Henry
>            Assignee: Rakhi Kumari
>            Priority: Major
>              Labels: api-addition
>             Fix For: proton-c-0.37.0
>
>
> Requesting support for setting the dynamic node properties be added to the 
> source and target options.
> This would allow the setting of termini node properties for senders and 
> receivers.
> Similar to the following request made for Python here: 
> https://issues.apache.org/jira/browse/PROTON-816



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to