[
https://issues.apache.org/jira/browse/DISPATCH-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484465#comment-17484465
]
ASF GitHub Bot commented on DISPATCH-1974:
------------------------------------------
jiridanek commented on pull request #1476:
URL: https://github.com/apache/qpid-dispatch/pull/1476#issuecomment-1025250409
I've merged the pylint addition. I probably will not do anything about
flake8 doc comment stuff because it just introduces large diffs to commit
history, which is undesirable at this point.
Maybe later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
> Key: DISPATCH-1974
> URL: https://issues.apache.org/jira/browse/DISPATCH-1974
> Project: Qpid Dispatch
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Jiri Daněk
> Priority: Major
> Fix For: Backlog
>
>
> Fixes with autopep8 in DISPATCH-1814 resolved many flake8 warnings. There are
> still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the
> tox.ini flake8 ignore section.
> h3. List of "useful" suppressed warnings
> {code}
> # H101: Use TODO(NAME)
> # H202: assertRaises Exception too broad
> # E722: do not use bare 'except'
> # H201: no 'except:' at least use 'except Exception:'
> # F811: redefinition of unused 'Timeout' from line 29
> # F405: may be undefined, or defined from star imports: datetime
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]