[
https://issues.apache.org/jira/browse/DISPATCH-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485512#comment-17485512
]
ASF GitHub Bot commented on DISPATCH-2321:
------------------------------------------
codecov-commenter commented on pull request #1508:
URL: https://github.com/apache/qpid-dispatch/pull/1508#issuecomment-1027345458
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1508](https://codecov.io/gh/apache/qpid-dispatch/pull/1508?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e28e9e0) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/542fa4035b9cd9cb74d448d518e388d2a18f7d68?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(542fa40) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head e28e9e0 differs from pull request most recent
head 975b97d. Consider uploading reports for the commit 975b97d to get more
accurate results
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
- Coverage 84.92% 84.90% -0.03%
==========================================
Files 116 116
Lines 28640 28640
==========================================
- Hits 24323 24317 -6
- Misses 4317 4323 +6
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j)
| `78.69% <0.00%> (-4.15%)` | :arrow_down: |
|
[src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==)
| `88.18% <0.00%> (-1.58%)` | :arrow_down: |
|
[src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=)
| `84.15% <0.00%> (-1.00%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==)
| `88.84% <0.00%> (+0.14%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.29% <0.00%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1508?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1508?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[542fa40...975b97d](https://codecov.io/gh/apache/qpid-dispatch/pull/1508?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add mypy check for the Python code, gradually add optional type annotations
> ---------------------------------------------------------------------------
>
> Key: DISPATCH-2321
> URL: https://issues.apache.org/jira/browse/DISPATCH-2321
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.18.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: 1.19.0
>
>
> Automated type checker is an important milestone on the road towards adding
> python type hints. Without it, one cannot know if the type hints are in
> agreement with each other across the whole codebase.
> The primary target for annotations is the router python code and the tools
> (qdmanage, qdstat, possibly also scrapper). Tests will not be meticulously
> annotated as part of this effort, except where individual people decide it is
> worth their time.
> What follows in my first PR is the initial CI job and few basic annotations.
> Contributions welcome.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
