[ https://issues.apache.org/jira/browse/PROTON-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jiri Daněk updated PROTON-2494: ------------------------------- Description: https://github.com/apache/qpid-proton/pull/356#pullrequestreview-872590821 {quote} I can see inconsistency between openssl and cyrus sasl libs. We don't seem to use pkgconfig for cyrus sasl in the same way as for openssl. ~And in fact we seem to have to work around not using pkg-config when we are on windows in a strange way! Also we include some (copied in) code to interface to pkgconfig, but there seems to be a good pypi package - pkgconfig which does this stuff and is geared up for use in setup.py too. Maybe we should be using this rather than the strange homegrown thing we've got? {quote} was: https://github.com/apache/qpid-proton/pull/356#pullrequestreview-872590821 {quote} I can see inconsistency between openssl and cyrus sasl libs. We don't seem to use pkgconfig for cyrus sasl in the same way as for openssl. ~And in fact we seem to have to work around not using pkg-config when we are on windows in a strange way! Also we include some (copied in) code to interface to pkgconfig, but there seems to be a good pypi package - pkgconfig which does this stuff and is geared up for use in setup.py too. Maybe we should be using this rather than the strange homegrown thing we've got?{quote} > Improve python-qpid-proton wheel build regarding pkgconfig and deps > ------------------------------------------------------------------- > > Key: PROTON-2494 > URL: https://issues.apache.org/jira/browse/PROTON-2494 > Project: Qpid Proton > Issue Type: Improvement > Components: build, python-binding > Affects Versions: proton-c-0.36.0 > Reporter: Jiri Daněk > Priority: Major > Fix For: proton-c-future > > > https://github.com/apache/qpid-proton/pull/356#pullrequestreview-872590821 > {quote} > I can see inconsistency between openssl and cyrus sasl libs. We don't seem to > use pkgconfig for cyrus sasl in the same way as for openssl. ~And in fact we > seem to have to work around not using pkg-config when we are on windows in a > strange way! > Also we include some (copied in) code to interface to pkgconfig, but there > seems to be a good pypi package - pkgconfig which does this stuff and is > geared up for use in setup.py too. Maybe we should be using this rather than > the strange homegrown thing we've got? > {quote} -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org