[
https://issues.apache.org/jira/browse/PROTON-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487123#comment-17487123
]
ASF GitHub Bot commented on PROTON-2492:
----------------------------------------
astitcher commented on a change in pull request #356:
URL: https://github.com/apache/qpid-proton/pull/356#discussion_r799556735
##########
File path: python/setup.py.in
##########
@@ -145,6 +146,7 @@ class Configure(build_ext):
# pkg-config for a minimum version 0. If it's installed, it should
# return True and we'll use it. Otherwise, we'll use the stub.
if misc.pkg_config_version_installed('openssl', atleast='0'):
+ library_dirs += [misc.pkg_config_get_var('openssl', 'libdir')]
libraries += ['ssl', 'crypto']
Review comment:
Well it's just not the usual way you'd use pkg-config! The essential
point of it is to tell you what extra flags you need in the compile and link
lines to get this library.
It's entirely possible to change what the libraries are called, or add extra
dependency libraries, if you look them up using pkg-config. Specifically in
this case the extra -lcrypto is not really obvious (except that everyone has
just to used to linking it now!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Python module linking on recent macOS fails with clang unable to find -lssl
> ---------------------------------------------------------------------------
>
> Key: PROTON-2492
> URL: https://issues.apache.org/jira/browse/PROTON-2492
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: proton-c-0.36.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: proton-c-0.37.0
>
>
> https://app.travis-ci.com/github/apache/qpid-proton/jobs/558190020
> {noformat}
> [...]
> Scanning dependencies of target py_pkg_wheel
> running bdist_wheel
> running build
> running build_py
> running build_ext
> running configure
> Did not find libqpid-proton-core via pkg-config:
> Building the bundled proton-c sources into the extension
> Using openssl version 1.1.1m (found via pkg-config)
> creating build
> creating build/temp.macosx-10.15-x86_64-3.9
> creating build/temp.macosx-10.15-x86_64-3.9/var
> creating build/temp.macosx-10.15-x86_64-3.9/var/folders
> [...]
> creating build/lib.macosx-10.15-x86_64-3.9
> clang -bundle -undefined dynamic_lookup -isysroot
> /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk
> build/temp.macosx-10.15-x86_64-3.9/cproton_wrap.o
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/log.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/codec.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/buffer.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/dispatcher.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/transport.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/memory.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/util.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/framing.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/encoder.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/logger.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/init.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/engine.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/frame_generators.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/error.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/event.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/types.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/value_dump.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/frame_consumers.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/decoder.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/connection_driver.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/autodetect.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/message.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/object/list.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/object/object.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/object/string.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/object/iterator.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/object/map.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/core/object/record.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/compiler/gcc/start.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/ssl/openssl.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/sasl/sasl.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/sasl/default_sasl.o
>
> build/temp.macosx-10.15-x86_64-3.9/Users/travis/build/apache/qpid-proton/build/python/dist/src/sasl/cyrus_sasl.o
> -lssl -lcrypto -lsasl2 -o
> build/lib.macosx-10.15-x86_64-3.9/_cproton.cpython-39-darwin.so
> ld: library not found for -lssl
> clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
> error: command '/usr/bin/clang' failed with exit code 1
> make[2]: *** [python/CMakeFiles/py_pkg_wheel] Error 1
> make[1]: *** [python/CMakeFiles/py_pkg_wheel.dir/all] Error 2
> make[1]: *** Waiting for unfinished jobs....
> [...]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
