jiridanek commented on a change in pull request #1512: URL: https://github.com/apache/qpid-dispatch/pull/1512#discussion_r804047423
########## File path: tests/system_tests_multi_tenancy.py ########## @@ -229,6 +231,17 @@ def test_16_two_router_anonymous_sender_tenant_on_both(self): test.run() self.assertIsNone(test.error) + def _cleanup_link_routes(func): Review comment: > Yeah in the end I'm punting on the decorator approach: too many issues with the python linters. If the only problem is the linter, that should not be hard to put right. Put the decorator as a standalone top level method in the module, and the warning you got should be gone! You were not relying on it being an instance method anyway. ```python def _cleanup_link_routes(func): @functools.wraps(func) def wrapper(self, *args, **kwargs): result = func(self, *args, **kwargs) # TODO something here return result return wrapper class TestClass(unittest.TestCae): def __init__(self, a=1, b=2): @decorate def test_something(self): pass ``` I'm not sure what other problems there might be with it. I'd have to actually try it, and I don't want to poke into tests that I don't understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org