[
https://issues.apache.org/jira/browse/DISPATCH-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493349#comment-17493349
]
ASF GitHub Bot commented on DISPATCH-2314:
------------------------------------------
codecov-commenter commented on pull request #1518:
URL: https://github.com/apache/qpid-dispatch/pull/1518#issuecomment-1041875374
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1518](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(65ef983) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/b7918db600decd9b610f8401ff306261674cfdb8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(b7918db) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1518 +/- ##
==========================================
+ Coverage 84.82% 84.86% +0.04%
==========================================
Files 117 117
Lines 28643 28642 -1
==========================================
+ Hits 24295 24307 +12
+ Misses 4348 4335 -13
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `93.71% <0.00%> (-0.56%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==)
| `88.69% <0.00%> (-0.01%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `94.00% <0.00%> (+0.09%)` | :arrow_up: |
|
[src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=)
| `85.75% <0.00%> (+0.12%)` | :arrow_up: |
|
[src/router\_core/modules/mobile\_sync/mobile.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvbW9iaWxlX3N5bmMvbW9iaWxlLmM=)
| `92.60% <0.00%> (+0.23%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `89.18% <0.00%> (+0.28%)` | :arrow_up: |
|
[src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=)
| `77.42% <0.00%> (+0.31%)` | :arrow_up: |
|
[src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j)
| `85.73% <0.00%> (+0.55%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.50% <0.00%> (+0.63%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[b7918db...65ef983](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> TSAN data race when setting the presettled flag
> -----------------------------------------------
>
> Key: DISPATCH-2314
> URL: https://issues.apache.org/jira/browse/DISPATCH-2314
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Reporter: Ganesh Murthy
> Priority: Major
> Labels: race-condition, tsan
>
> {noformat}
> 21: E Process 2380 error: exit code 66, expected 0
> 21: E qdrouterd -c test-router.conf -I
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
> 21: E
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/system_test.dir/system_tests_one_router/OneRouterTest/setUpClass/test-router-9.cmd
> 21: E >>>>
> 21: E ==================
> 21: E WARNING: ThreadSanitizer: data race (pid=2380)
> 21: E Write of size 1 at 0x7b440003d355 by thread T4:
> 21: E #0 qdr_delivery_set_presettled
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:136
> (qdrouterd+0x49d8c5)
> 21: E #1 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:538
> (qdrouterd+0x4d2ff5)
> 21: E #2 deferred_AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:922
> (qdrouterd+0x4d37b2)
> 21: E #3 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:801
> (qdrouterd+0x4d584b)
> 21: E #4 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:790
> (qdrouterd+0x4d8b16)
> 21: E #5 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1058
> (qdrouterd+0x4d8b16)
> 21: E #6 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #7 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Previous read of size 1 at 0x7b440003d355 by thread T1:
> 21: E #0 qdr_delivery_continue_CT
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:1108
> (qdrouterd+0x49f9e2)
> 21: E #1 router_core_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0x4b572a)
> 21: E #2 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Location is heap block of size 320 at 0x7b440003d2c0
> allocated by thread T3:
> 21: E #0 posix_memalign <null> (libtsan.so.0+0x32a23)
> 21: E #1 qd_alloc
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:391
> (qdrouterd+0x44ad29)
> 21: E #2 new_qdr_delivery_t
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:24
> (qdrouterd+0x49d33c)
> 21: E #3 qdr_link_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:64
> (qdrouterd+0x4bb125)
> 21: E #4 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:877
> (qdrouterd+0x4d3106)
> 21: E #5 do_receive
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:219
> (qdrouterd+0x45f234)
> 21: E #6 qd_container_handle_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:734
> (qdrouterd+0x45f234)
> 21: E #7 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1108
> (qdrouterd+0x4d8b41)
> 21: E #8 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #9 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Thread T4 (tid=2385, running) created by main thread at:
> 21: E #0 pthread_create <null> (libtsan.so.0+0x5bef5)
> 21: E #1 sys_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
> (qdrouterd+0x481a9c)
> 21: E #2 qd_server_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1525
> (qdrouterd+0x4dba3c)
> 21: E #3 main_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
> (qdrouterd+0x426e5c)
> 21: E #4 main
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x42626c)
> 21: E
> 21: E Thread T1 (tid=2382, running) created by main thread at:
> 21: E #0 pthread_create <null> (libtsan.so.0+0x5bef5)
> 21: E #1 sys_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
> (qdrouterd+0x481a9c)
> 21: E #2 qdr_core
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core.c:124
> (qdrouterd+0x4af670)
> 21: E #3 qd_router_setup_late
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:2127
> (qdrouterd+0x4d3f18)
> 21: E #4 ffi_call_unix64 <null> (libffi.so.6+0x6c03)
> 21: E #5 main_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x426dfc)
> 21: E #6 main
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x42626c)
> 21: E
> 21: E Thread T3 (tid=2384, running) created by main thread at:
> 21: E #0 pthread_create <null> (libtsan.so.0+0x5bef5)
> 21: E #1 sys_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
> (qdrouterd+0x481a9c)
> 21: E #2 qd_server_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1525
> (qdrouterd+0x4dba3c)
> 21: E #3 main_process
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
> (qdrouterd+0x426e5c)
> 21: E #4 main
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x42626c)
> 21: E
> 21: E SUMMARY: ThreadSanitizer: data race
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:136
> in qdr_delivery_set_presettled
> 21: E ==================
> 21: E ThreadSanitizer: reported 1 warnings {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
